[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CC7F352.5030008@ge.com>
Date: Wed, 27 Oct 2010 10:39:30 +0100
From: Martyn Welch <martyn.welch@...com>
To: "Emilio G. Cota" <cota@...ap.org>
CC: Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>,
devel@...verdev.osuosl.org,
Juan David Gonzalez Cobas <david.cobas@...il.com>,
Bill Pemberton <wfp5p@...ginia.edu>
Subject: Re: [PATCH 03/30] staging/vme_user: remove unreachable line
On 26/10/10 02:10, Emilio G. Cota wrote:
> From: Emilio G. Cota <cota@...ap.org>
>
> Signed-off-by: Emilio G. Cota <cota@...ap.org>
This line was provided to aid future development. It is the command
needed to undo the last function call to the function.
On balance I guess this is as likely to end up causing as many problems
as it aims to solve, so I guess it's worth getting rid of it:
Acked-by: Martyn Welch <martyn.welch@...com>
> ---
> drivers/staging/vme/devices/vme_user.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index a6f6116..bdc4e1e 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -654,7 +654,6 @@ static int __init vme_user_init(void)
>
> return retval;
>
> - vme_unregister_driver(&vme_user_driver);
> err_reg:
> kfree(ids);
> err_id:
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square,
Manchester,
E martyn.welch@...com | M2 3AB VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists