linux-kernel - Re: [PATCH 3/8] KVM: fix searching async gfn in kvm_async_pf_gfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101027102913.GM26191@redhat.com>
Date:	Wed, 27 Oct 2010 12:29:13 +0200
From:	Gleb Natapov <gleb@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
Cc:	Avi Kivity <avi@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH 3/8] KVM: fix searching async gfn in
 kvm_async_pf_gfn_slot

On Wed, Oct 27, 2010 at 05:03:33PM +0800, Xiao Guangrong wrote:
> The 'gfn' is not recorded if the next slot is empty
> 
This function is not used for gfn recording, only to search for recorded
gfn, but without the fix it walks over all entries if gfn is not in the
hash.

> Signed-off-by: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
Acked-by: Gleb Natapov <gleb@...hat.com>

> ---
>  arch/x86/kvm/x86.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 7876ec8..16f42ff 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -6207,8 +6207,8 @@ static u32 kvm_async_pf_gfn_slot(struct kvm_vcpu *vcpu, gfn_t gfn)
>  	u32 key = kvm_async_pf_hash_fn(gfn);
>  
>  	for (i = 0; i < roundup_pow_of_two(ASYNC_PF_PER_VCPU) &&
> -		     (vcpu->arch.apf.gfns[key] != gfn ||
> -		      vcpu->arch.apf.gfns[key] == ~0); i++)
> +		     (vcpu->arch.apf.gfns[key] != gfn &&
> +		      vcpu->arch.apf.gfns[key] != ~0); i++)
>  		key = kvm_async_pf_next_probe(key);
>  
>  	return key;
> -- 
> 1.7.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/