linux-kernel - Re: [PATCH 09/30] staging/vme: fill in struct device's .release, even if it's a NOOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC804FF.9050908@ge.com>
Date:	Wed, 27 Oct 2010 11:54:55 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	"Emilio G. Cota" <cota@...ap.org>
CC:	Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org,
	Juan David Gonzalez Cobas <david.cobas@...il.com>,
	Bill Pemberton <wfp5p@...ginia.edu>
Subject: Re: [PATCH 09/30] staging/vme: fill in struct device's .release,
 even if it's a NOOP

On 26/10/10 02:10, Emilio G. Cota wrote:
> From: Emilio G. Cota <cota@...ap.org>
> 
> Without it we get 32 warnings, one per device being released, when
> removing a bridge module.
> 
> After applying this patch, bridge modules can at last be removed
> without any apparent hiccup.
> 
> [Note: tested only on the tsi148, it's the only bridge I've got]
> 

I guess this is an artifact of the current lack of refcounting?

This is definitely an issue, however I don't think masking it by adding
an empty function is the correct way to go.

Martyn

> Signed-off-by: Emilio G. Cota <cota@...ap.org>
> ---
>  drivers/staging/vme/vme.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index afd2dbd..59650dd 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -1352,6 +1352,11 @@ static void vme_free_bus_num(int bus)
>  	mutex_unlock(&vme_bus_num_mtx);
>  }
>  
> +/* Note: device_release(dev) throws a warning if dev->release isn't filled in */
> +static void vme_dev_release(struct device *dev)
> +{
> +}
> +
>  int vme_register_bridge(struct vme_bridge *bridge)
>  {
>  	struct device *dev;
> @@ -1372,6 +1377,7 @@ int vme_register_bridge(struct vme_bridge *bridge)
>  
>  		dev->parent = bridge->parent;
>  		dev->bus = &vme_bus_type;
> +		dev->release = vme_dev_release;
>  		/*
>  		 * We save a pointer to the bridge in platform_data so that we
>  		 * can get to it later. We keep driver_data for use by the


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square,
Manchester,
E martyn.welch@...com                        |   M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/