linux-kernel - [tip:perf/urgent] perf record: Remove newline character from perror() argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-0ab7368f8dad561b6164b3e942cab00f9565bd37@git.kernel.org>
Date:	Wed, 27 Oct 2010 11:01:05 GMT
From:	tip-bot for Matt Fleming <matt@...sole-pimps.org>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, paulus@...ba.org, hpa@...or.com,
	mingo@...hat.com, tzanussi@...il.com, peterz@...radead.org,
	fweisbec@...il.com, matt@...sole-pimps.org, tglx@...utronix.de,
	acme@...icio.ghostprotocols.net, mingo@...e.hu
Subject: [tip:perf/urgent] perf record: Remove newline character from perror() argument

Commit-ID:  0ab7368f8dad561b6164b3e942cab00f9565bd37
Gitweb:     http://git.kernel.org/tip/0ab7368f8dad561b6164b3e942cab00f9565bd37
Author:     Matt Fleming <matt@...sole-pimps.org>
AuthorDate: Sat, 28 Aug 2010 16:46:19 +0100
Committer:  Arnaldo Carvalho de Melo <acme@...icio.ghostprotocols.net>
CommitDate: Tue, 26 Oct 2010 13:03:09 -0200

perf record: Remove newline character from perror() argument

If we include a newline character in the string argument to perror()
then the output will be split across two lines like so,

    Unable to read perf file descriptor
    : No space left on device

Deleting the newline character prints a much more readable error,

    Unable to read perf file descriptor: No space left on device

Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Paul Mackerras <paulus@...ba.org>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Tom Zanussi <tzanussi@...il.com>
LKML-Reference: <89e77b54659bc3798b23a5596c2debb7f6f4cf27.1283010281.git.matt@...sole-pimps.org>
Signed-off-by: Matt Fleming <matt@...sole-pimps.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@...icio.ghostprotocols.net>
---
 tools/perf/builtin-record.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index ff77b80..b530bee 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -353,7 +353,7 @@ try_again:
 		}
 
 		if (read(fd[nr_cpu][counter][thread_index], &read_data, sizeof(read_data)) == -1) {
-			perror("Unable to read perf file descriptor\n");
+			perror("Unable to read perf file descriptor");
 			exit(-1);
 		}
 
@@ -626,7 +626,7 @@ static int __cmd_record(int argc, const char **argv)
 
 	nr_cpus = read_cpu_map(cpu_list);
 	if (nr_cpus < 1) {
-		perror("failed to collect number of CPUs\n");
+		perror("failed to collect number of CPUs");
 		return -1;
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/