linux-kernel - Re: [PATCH 13/30] staging/vme_user: declare private variables as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC80D20.5060504@ge.com>
Date:	Wed, 27 Oct 2010 12:29:36 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	"Emilio G. Cota" <cota@...ap.org>
CC:	Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org,
	Juan David Gonzalez Cobas <david.cobas@...il.com>,
	Bill Pemberton <wfp5p@...ginia.edu>
Subject: Re: [PATCH 13/30] staging/vme_user: declare private variables as
 static

On 26/10/10 02:10, Emilio G. Cota wrote:
> From: Emilio G. Cota <cota@...ap.org>
> 
> Signed-off-by: Emilio G. Cota <cota@...ap.org>

Acked-by: Martyn Welch <martyn.welch@...com>

> ---
>  drivers/staging/vme/devices/vme_user.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index bdc4e1e..31a74e2 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -114,9 +114,9 @@ typedef struct {
>  } driver_stats_t;
>  static driver_stats_t statistics;
>  
> -struct cdev *vme_user_cdev;		/* Character device */
> -struct class *vme_user_sysfs_class;	/* Sysfs class */
> -struct device *vme_user_bridge;		/* Pointer to the bridge device */
> +static struct cdev *vme_user_cdev;		/* Character device */
> +static struct class *vme_user_sysfs_class;	/* Sysfs class */
> +static struct device *vme_user_bridge;		/* Pointer to the bridge device */
>  
>  
>  static const int type[VME_DEVS] = {	MASTER_MINOR,	MASTER_MINOR,


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square,
Manchester,
E martyn.welch@...com                        |   M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/