linux-kernel - Re: [PATCH 24/30] staging/vme_user: remove unnecessary call to vme_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Oct 2010 13:24:55 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	"Emilio G. Cota" <cota@...ap.org>
CC:	Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org,
	Juan David Gonzalez Cobas <david.cobas@...il.com>,
	Bill Pemberton <wfp5p@...ginia.edu>
Subject: Re: [PATCH 24/30] staging/vme_user: remove unnecessary call to vme_slave_set

On 26/10/10 02:11, Emilio G. Cota wrote:
> From: Emilio G. Cota <cota@...ap.org>
> 
> The resource is about to be freed and therefore it is pointless to
> set any of its parameters.

Nope - this is disabling the window, which given that you are about to
unalloc the memory that it is using this is quite important.

Martyn

> 
> Signed-off-by: Emilio G. Cota <cota@...ap.org>
> ---
>  drivers/staging/vme/devices/vme_user.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 95c22ff..a1cb85b 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -851,7 +851,6 @@ static int __devexit vme_user_remove(struct device *dev, int cur_bus, int cur_sl
>  		kfree(image[i].kern_buf);
>  
>  	for (i = SLAVE_MINOR; i < (SLAVE_MAX + 1); i++) {
> -		vme_slave_set(image[i].resource, 0, 0, 0, 0, VME_A32, 0);
>  		buf_unalloc(i);
>  		vme_slave_free(image[i].resource);
>  	}


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square,
Manchester,
E martyn.welch@...com                        |   M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/