linux-kernel - Re: [patch 116/176] fs: allow for more than 2^31 files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1288183562.2709.94.camel@edumazet-laptop>
Date:	Wed, 27 Oct 2010 14:46:02 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Christoph Hellwig <hch@....de>
Cc:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	davem@...emloft.net, holt@....com, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 116/176] fs: allow for more than 2^31 files

Le mercredi 27 octobre 2010 à 13:59 +0200, Christoph Hellwig a écrit :
> This patch breaks the binary sysctl ABI.  It probably doesn't matter
> as no one actually used it, but it might be better idea to just remove
> this node from the binary sysctl tree.
> 

Good point

To be precise, sysctl() truncates the value to low order 32bit value,
because it internally uses simple_strtoul(), then a put_user()

An old binary using sysctl() to fetch FS_MAXFILE could break on SGI
machines. I am not sure we should remove sysctl FS_MAXFILE because of
this rare case.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/