lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Oct 2010 18:00:44 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Joe Perches <joe@...ches.com> Cc: Jiri Kosina <trivial@...nel.org>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use On Oct 26, 2010, at 5:46 PM, Joe Perches <joe@...ches.com> wrote: > On Tue, 2010-10-26 at 17:40 -0700, Dmitry Torokhov wrote: >>> Mind if I move the time to the front like this? >>> +#define dbg(format, arg...) \ >>> +do { \ >>> + if (i8042_debug) \ >>> + printk(KERN_DEBUG KBUILD_MODNAME ": [%d]" format), \ >>> + (int)(jiffies - i8042_start_time), ##arg); \ >>> +} while (0) >> Another option would be to leave '\n' in dbg() and leave most of the >> callers as is. > > That's really error prone though. > In what way? -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists