linux-kernel - Re: [PATCH 24/30] staging/vme_user: remove unnecessary call to vme_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101027145947.GQ10869@flamenco.cs.columbia.edu>
Date:	Wed, 27 Oct 2010 10:59:47 -0400
From:	"Emilio G. Cota" <cota@...ap.org>
To:	Martyn Welch <martyn.welch@...com>
Cc:	Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org,
	Juan David Gonzalez Cobas <david.cobas@...il.com>,
	Bill Pemberton <wfp5p@...ginia.edu>
Subject: Re: [PATCH 24/30] staging/vme_user: remove unnecessary call to
 vme_slave_set

On Wed, Oct 27, 2010 at 13:24:55 +0100, Martyn Welch wrote:
> On 26/10/10 02:11, Emilio G. Cota wrote:
> > From: Emilio G. Cota <cota@...ap.org>
> > 
> > The resource is about to be freed and therefore it is pointless to
> > set any of its parameters.
> 
> Nope - this is disabling the window, which given that you are about to
> unalloc the memory that it is using this is quite important.

Aah I didn't realise that 

> > -		vme_slave_set(image[i].resource, 0, 0, 0, 0, VME_A32, 0);

disables the window. I thought vme_slave_free would disable it as well.
Forget this one, then.

Thanks

		Emilio

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/