linux-kernel - Re: DVB: af9015 defunct [was: mmotm 2010-10-20-15-01 uploaded]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Oct 2010 18:36:35 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mm-commits@...r.kernel.org, Antti Palosaari <crope@....fi>,
	Greg KH <gregkh@...e.de>, USB list <linux-usb@...r.kernel.org>
Subject: Re: DVB: af9015 defunct [was: mmotm 2010-10-20-15-01 uploaded]

On 10/27/2010 06:12 PM, Mauro Carvalho Chehab wrote:
> Em 22-10-2010 12:06, Jiri Slaby escreveu:
>> On 10/22/2010 03:56 PM, Mauro Carvalho Chehab wrote:
>>> --- a/drivers/media/dvb/dvb-usb/af9015.c
>>> +++ b/drivers/media/dvb/dvb-usb/af9015.c
>>> @@ -1144,7 +1144,7 @@ static struct qt1010_config af9015_qt1010_config = {
>>>  
>>>  static struct tda18271_config af9015_tda18271_config = {
>>>  	.gate = TDA18271_GATE_DIGITAL,
>>> -	.small_i2c = 1,
>>> +	.small_i2c = TDA18271_16_BYTE_CHUNK_INIT;,
>>
>> No, it doesn't help (note the i2c line which prints the small_i2c entry):
>> dvb-usb: found a 'Leadtek WinFast DTV Dongle Gold' in cold state, will
>> try to load a firmware
>> dvb-usb: downloading firmware from file 'dvb-usb-af9015.fw'
>> dvb-usb: found a 'Leadtek WinFast DTV Dongle Gold' in warm state.
>> dvb-usb: will pass the complete MPEG2 transport stream to the software
>> demuxer.
>> DVB: registering new adapter (Leadtek WinFast DTV Dongle Gold)
>> af9013: firmware version:4.95.0.0
>> DVB: registering adapter 0 frontend 0 (Afatech AF9013 DVB-T)...
>> af9015_tuner_attach: i2c 16
>> tda18271 16-00c0: creating new instance
>> TDA18271HD/C2 detected @ 16-00c0
>> af9015: command failed:1
> 
>> tda18271_write_regs: [16-00c0|M] ERROR: idx = 0x0, len = 39,
>> i2c_transfer returned: -1
> 
> Hmm...
> 
> int tda18271_write_regs(struct dvb_frontend *fe, int idx, int len)
> {
> ...
>         switch (priv->small_i2c) {
>         case TDA18271_03_BYTE_CHUNK_INIT:
>                 max = 3;
>                 break;
>         case TDA18271_08_BYTE_CHUNK_INIT:
>                 max = 8;
>                 break;
>         case TDA18271_16_BYTE_CHUNK_INIT:
>                 max = 16;
>                 break;
>         case TDA18271_39_BYTE_CHUNK_INIT:
>         default:
>                 max = 39;
>         }
> 
> 
> with small_i2c = 1, the driver will not restrict the maximum length size.

Actually it will make it 39.

> It's weird that the patch didn't fix it. Are you sure that reverting this
> patch is enough to make the driver work?

Yes, I'm 100% sure.

> Please test this one.
> 
> It will properly log the size of the message the driver tried to use, and will
> reduce the max number of bytes per I2C transfer to 8.

Yes, this one works. And to be sure that 16 doesn't work I unplugged and
replugged the device (I didn't last time). And boom, it works too. So
.small_i2c = TDA18271_16_BYTE_CHUNK_INIT fixes the issue as well.

> --- a/drivers/media/dvb/dvb-usb/af9015.c
> +++ b/drivers/media/dvb/dvb-usb/af9015.c
> @@ -1131,7 +1131,7 @@ static struct qt1010_config af9015_qt1010_config = {
>  
>  static struct tda18271_config af9015_tda18271_config = {
>  	.gate = TDA18271_GATE_DIGITAL,
> -	.small_i2c = 1,
> +	.small_i2c = TDA18271_08_BYTE_CHUNK_INIT,
>  };
>  
>  static struct mxl5005s_config af9015_mxl5003_config = {

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/