| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Oct 2010 17:20:20 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: David Miller <davem@...emloft.net> Cc: jbaron@...hat.com, linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org Subject: Re: [PATCH] jump_label: Fix unaligned traps on sparc. On Sat, 2010-10-23 at 11:06 -0700, David Miller wrote: > The vmlinux.lds.h knobs to emit the __jump_table section in the main > kernel image takes care to align the section, but this doesn't help > for the __jump_table section that gets emitted into modules. > > Fix the resulting lack of section alignment by explicitly specifying > it in the assembler. > > Signed-off-by: David S. Miller <davem@...emloft.net> Thanks! I'll pull this in tonight with the other jump label patches. Unfortunately, it turns out that gcc has a bug that can cause crashes when jump label is used. We need to set it to broken until gcc has a fix and we can detect if the compiler has the bug or not. -- Steve > > diff --git a/arch/sparc/include/asm/jump_label.h b/arch/sparc/include/asm/jump_label.h > index 62e66d7..d95cf44 100644 > --- a/arch/sparc/include/asm/jump_label.h > +++ b/arch/sparc/include/asm/jump_label.h > @@ -14,6 +14,7 @@ > "nop\n\t" \ > "nop\n\t" \ > ".pushsection __jump_table, \"a\"\n\t"\ > + ".align 4\n\t" \ > ".word 1b, %l[" #label "], %c0\n\t" \ > ".popsection \n\t" \ > : : "i" (key) : : label);\ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists