linux-kernel - Re: [PATCH] initramfs: Fix build break on symbol-prefixed archs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinpD8NR-pBLfWV9uan-+MYddFQGtjMx0qhAG_n9@mail.gmail.com>
Date:	Wed, 27 Oct 2010 19:58:29 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
	Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
	tabbott@...lice.com, vda.linux@...glemail.com, hpa@...ux.intel.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	heiko.carstens@...ibm.com, schwidefsky@...ibm.com,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH] initramfs: Fix build break on symbol-prefixed archs

On Wed, Oct 27, 2010 at 19:33, Michal Marek wrote:
> On 28.10.2010 01:10, Mike Frysinger wrote:
>> On Wed, Oct 27, 2010 at 18:46, Michal Marek wrote:
>>> On 27.10.2010 20:23, Mike Frysinger wrote:
>>>> can we get this change dropped from linux-next until someone gets a
>>>> chance to fix it ?
>>>
>>> Sorry I missed this thread. So your last patch
>>> (http://lkml.org/lkml/2010/10/19/488) did fix the Blackfin build
>>> failure? Can you submit it with a proper Signed-off-by and changelog?
>>
>> it shouldnt be a sep change.  it should be squashed into the broken
>> one so that the result works.
>
> The breakage already happened and I don't want to rewind the branch now.

if it isnt going to be merged until 2.6.38 merge window, i dont see
what the problem is with squashing a change into it.

> The worst that can happen is that if you bisect into ffe8018 you'll get
> a tree that does not build on Blackfin.

and h8300.  i thought there was another symbol prefix arch than just
these two, but my grep isnt showing it atm.

 The previous commit works and
> the next will do as well if you submit the patch.

if my change is going in after your bad commit, then you can squash it
with a simple `git commit --amend`.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/