linux-kernel - Re: [PATCH 8/14] drivers/platform/x86/thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1010270658480.31668@ask.diku.dk>
Date:	Wed, 27 Oct 2010 07:03:08 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	kernel-janitors@...r.kernel.org, Matthew Garrett <mjg@...hat.com>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double
 assignment

On Tue, 26 Oct 2010, Henrique de Moraes Holschuh wrote:

> On Tue, 26 Oct 2010, Julia Lawall wrote:
> > From: Julia Lawall <julia@...u.dk>
> > 
> > Delete successive assignments to the same location.
> 
> There are often results of mismerges or other assorted screw ups, often
> done by the maintainer itself (e.g. me in thinkpad-acpi's case) during
> development.
> 
> The patch is correct, and I thank you for the head's up.  But let me
> track down what caused it first, hmm?  I also highly recommend that this
> should be done in all cases you find, instead of just blindly fixing the
> assignment.  I suggest using git --blame to track down what added the
> duplicated assignments, and check if it looks sane...
> 
> It is often a VERY BAD IDEA to remove such markers of potential
> brokennes without checking out if they're actually helpfully trying to
> warn you of worse badness :p
> 
> But hey, maybe you've already done that.  If you did, I apologise for
> preaching to the choir.

I didn't look for the original source of the problem, except in the case 
of [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c where I found it 
already in the pre-git era.  Thanks fo rthe suggestion.  On the other 
hand, I was very selective about which code I changed.  In particular I 
left a number of cases like:

x = NULL; // or 0 etc
x = foo(...); // ie a NULL returning function

I figured that this isn't hurting anything, and perhaps it is informative 
about what kind of value foo might return.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/