linux-kernel - Re: [PATCH 8/14] drivers/platform/x86/thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC7D238.9010903@bfs.de>
Date:	Wed, 27 Oct 2010 09:18:16 +0200
From:	walter harms <wharms@....de>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
CC:	Julia Lawall <julia@...u.dk>, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: delete double
 assignment



Henrique de Moraes Holschuh schrieb:
> On Tue, 26 Oct 2010, Julia Lawall wrote:
>> From: Julia Lawall <julia@...u.dk>
>>
>> Delete successive assignments to the same location.
> 
> There are often results of mismerges or other assorted screw ups, often
> done by the maintainer itself (e.g. me in thinkpad-acpi's case) during
> development.
> 
> The patch is correct, and I thank you for the head's up.  But let me
> track down what caused it first, hmm?  I also highly recommend that this
> should be done in all cases you find, instead of just blindly fixing the
> assignment.  I suggest using git --blame to track down what added the
> duplicated assignments, and check if it looks sane...
> 
> It is often a VERY BAD IDEA to remove such markers of potential
> brokennes without checking out if they're actually helpfully trying to
> warn you of worse badness :p
> 
> But hey, maybe you've already done that.  If you did, I apologise for
> preaching to the choir.
> 

IMHO that goes beyond what to expect from a kernel janitor. They try to
identify minor problems like double inits; why they occur is part of the
"maintainer job". The people (should) have much better understand of the
code and can identify omissions in there work flow much more easy. To be
fair some problems are hard to identify/fix but you can not move that to
the janitor.

just my 2 cents,
 wh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/