linux-kernel - Re: bug in streamline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1288274585.18238.241.camel@gandalf.stny.rr.com>
Date:	Thu, 28 Oct 2010 10:03:05 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	member graysky <graysky@...hlinux.us>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: bug in streamline_config.pl

OK, you just found a bug ;-)

You complained about CONFIG_DRM_RADEON being selected (that's ATI
Radean). Here's why:

CONFIG_DRM_RADEON select by dependency on HWMON
CONFIG_HWMON_VID selected by direct module hwmon_vid

You had hwmon_vid enabled. This module gets selected by other modules,
one being DRM_RADEON.

If a module is selected by other modules and does not have a prompt to
select itself, then I have to select the other modules because I don't
know what module is needed to make sure this module is selected (again,
I can add logic to see if the select is satisfied by the direct
selections).

But, (here's the bug) HWMON has a prompt!  But it's a different kind of
prompt. It's a menuconfig option and not a config option. By making this
one-liner fix, I just removed the following options from your config:

 CONFIG_HOTPLUG_PCI=m
 CONFIG_RFKILL=m
 CONFIG_SFC=m
 CONFIG_DRM=m
 CONFIG_DRM_KMS_HELPER=m
 CONFIG_DRM_RADEON=m
 CONFIG_DRM_I915=m
 CONFIG_FB_DDC=m
 CONFIG_FB_NVIDIA=m
 CONFIG_FB_RIVA=m
 CONFIG_FB_RADEON=m
 CONFIG_FB_SAVAGE=m
 CONFIG_FB_3DFX=m
 CONFIG_DRM_NOUVEAU=m
 CONFIG_THINKPAD_ACPI=m
 CONFIG_EEEPC_LAPTOP=m

I'll go ahead and make sure that this fix makes it into 2.6.37

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/