linux-kernel - linux-next: manual merge of the fsnotify tree with Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20101028123815.4afc6805.sfr@canb.auug.org.au>
Date:	Thu, 28 Oct 2010 12:38:15 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Eric Paris <eparis@...hat.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: linux-next: manual merge of the fsnotify tree with Linus' tree

Hi Eric,

Today's linux-next merge of the fsnotify tree got a conflict in
fs/notify/fsnotify.c between commit
4d4eb36679adbdd75495e1bbfe7ac40e4ae41dea ("fsnotify: use dget_parent")
from Linus' tree and commit b14be22c572d5d98e2ffebf63e2d1aa1f088875b
("fsnotify: call fsnotify_parent in perm events") from the fsnotify tree.

Just context changes.  I fixed it up (see below) and can carry the fix as
necessary.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

diff --cc fs/notify/fsnotify.c
index 4498a20,f3f6aa7..0000000
--- a/fs/notify/fsnotify.c
+++ b/fs/notify/fsnotify.c
@@@ -88,32 -88,58 +88,35 @@@ int __fsnotify_parent(struct path *path
  {
  	struct dentry *parent;
  	struct inode *p_inode;
 -	bool send = false;
 -	bool should_update_children = false;
+ 	int ret = 0;
  
  	if (!dentry)
  		dentry = path->dentry;
  
  	if (!(dentry->d_flags & DCACHE_FSNOTIFY_PARENT_WATCHED))
- 		return;
+ 		return 0;
  
 -	spin_lock(&dentry->d_lock);
 -	parent = dentry->d_parent;
 +	parent = dget_parent(dentry);
  	p_inode = parent->d_inode;
  
 -	if (fsnotify_inode_watches_children(p_inode)) {
 -		if (p_inode->i_fsnotify_mask & mask) {
 -			dget(parent);
 -			send = true;
 -		}
 -	} else {
 -		/*
 -		 * The parent doesn't care about events on it's children but
 -		 * at least one child thought it did.  We need to run all the
 -		 * children and update their d_flags to let them know p_inode
 -		 * doesn't care about them any more.
 -		 */
 -		dget(parent);
 -		should_update_children = true;
 -	}
 -
 -	spin_unlock(&dentry->d_lock);
 -
 -	if (send) {
 +	if (unlikely(!fsnotify_inode_watches_children(p_inode)))
 +		__fsnotify_update_child_dentry_flags(p_inode);
 +	else if (p_inode->i_fsnotify_mask & mask) {
  		/* we are notifying a parent so come up with the new mask which
  		 * specifies these are events which came from a child. */
  		mask |= FS_EVENT_ON_CHILD;
  
  		if (path)
- 			fsnotify(p_inode, mask, path, FSNOTIFY_EVENT_PATH,
- 				 dentry->d_name.name, 0);
+ 			ret = fsnotify(p_inode, mask, path, FSNOTIFY_EVENT_PATH,
+ 				       dentry->d_name.name, 0);
  		else
- 			fsnotify(p_inode, mask, dentry->d_inode, FSNOTIFY_EVENT_INODE,
- 				 dentry->d_name.name, 0);
+ 			ret = fsnotify(p_inode, mask, dentry->d_inode, FSNOTIFY_EVENT_INODE,
+ 				       dentry->d_name.name, 0);
 -		dput(parent);
  	}
  
 -	if (unlikely(should_update_children)) {
 -		__fsnotify_update_child_dentry_flags(p_inode);
 -		dput(parent);
 -	}
 +	dput(parent);
+ 
+ 	return ret;
  }
  EXPORT_SYMBOL_GPL(__fsnotify_parent);
  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/