linux-kernel - Re: [PATCH] genirq: handle shared irqs in handle_nested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1010282053180.2692@localhost6.localdomain6>
Date:	Thu, 28 Oct 2010 20:54:18 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Rabin Vincent <rabin@....in>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genirq: handle shared irqs in handle_nested_irq()

On Thu, 28 Oct 2010, Rabin Vincent wrote:

> Allow shared irqs to work when nested threads are used for handling
> threaded interrupts.

Why do we want this ? handle_nested_irq() is called from a interrupt
demultiplexer, so why would we need shared interrupts for this ?

Thanks,

	tglx
 
> Signed-off-by: Rabin Vincent <rabin@....in>
> ---
>  kernel/irq/chip.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index baa5c4a..94a45a9 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -418,8 +418,8 @@ static inline void unmask_irq(struct irq_desc *desc)
>  void handle_nested_irq(unsigned int irq)
>  {
>  	struct irq_desc *desc = irq_to_desc(irq);
> +	irqreturn_t action_ret = IRQ_NONE;
>  	struct irqaction *action;
> -	irqreturn_t action_ret;
>  
>  	might_sleep();
>  
> @@ -434,7 +434,10 @@ void handle_nested_irq(unsigned int irq)
>  	desc->status |= IRQ_INPROGRESS;
>  	raw_spin_unlock_irq(&desc->lock);
>  
> -	action_ret = action->thread_fn(action->irq, action->dev_id);
> +	do {
> +		action_ret |= action->thread_fn(action->irq, action->dev_id);
> +		action = action->next;
> +	} while (action);
>  	if (!noirqdebug)
>  		note_interrupt(irq, desc, action_ret);
>  
> -- 
> 1.7.2.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/