linux-kernel - Re: [GIT PULL] battery-2.6.git (a last minute fix)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101028205605.GB3116@sortiz-mobl>
Date:	Thu, 28 Oct 2010 22:58:55 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
	Grazvydas Ignotas <notasas@...il.com>,
	Felipe Balbi <balbi@...com>
Subject: Re: [GIT PULL] battery-2.6.git (a last minute fix)

Hi Anton,

On Thu, Oct 28, 2010 at 01:09:53PM +0400, Anton Vorontsov wrote:
> On Thu, Oct 28, 2010 at 12:07:10AM -0700, Andrew Morton wrote:
> [...]
> > > The new driver does not build at its own commit point either, as the missing symbol 
> > > definition is simply not there. It appears that commit 2e727f1 could not have been 
> > > build-tested by anyone before it got upstream (let alone boot and functionality 
> > > tested). As a temporary workaround i'm disabling it in -tip.
> > > 
> > 
> > Those definitions get added by the MFD tree and used by the battery
> > tree.  Things arrived in the wrong order (and, yes, didn't get tested).
> 
> My bad. :-/
>
> > The fix is for Samuel to get a wiggle on with his merge?  The -rc1
> > window is about to slam shut on his fingers anyway.
> 
> I guess the best thing for now would be to be safe and to disable
> the new driver via 'depends on BROKEN', so it won't scare testers
> away from -rc1.
I'm about to send my pull request to Linus. Should I send this commit revert
as part of the pull request, or do you want to do it ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/