linux-kernel - [patch] misc/apds9802als: signedness bug in als_sensing_range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20101028044111.GT6062@bicker>
Date:	Thu, 28 Oct 2010 06:41:11 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Hong Liu <hong.liu@...el.com>
Cc:	Alan Cox <alan@...ux.intel.com>,
	Anantha Narayanan <anantha.narayanan@...el.com>,
	Jonathan Cameron <jic23@....ac.uk>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [patch] misc/apds9802als: signedness bug in
	als_sensing_range_store()

The error handling breaks if "ret_val" is unsigned here.

Signed-off-by: Dan Carpenter <error27@...il.com>

diff --git a/drivers/misc/apds9802als.c b/drivers/misc/apds9802als.c
index f9b91ba..0ed0935 100644
--- a/drivers/misc/apds9802als.c
+++ b/drivers/misc/apds9802als.c
@@ -123,7 +123,7 @@ static ssize_t als_sensing_range_store(struct device *dev,
 {
 	struct i2c_client *client = to_i2c_client(dev);
 	struct als_data *data = i2c_get_clientdata(client);
-	unsigned int ret_val;
+	int ret_val;
 	unsigned long val;
 
 	if (strict_strtoul(buf, 10, &val))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/