linux-kernel - Re: [PATCH -v3] x86: Disable x2apic if nox2apic is specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CCA773F.6000809@kernel.org>
Date:	Fri, 29 Oct 2010 00:26:55 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Len Brown <lenb@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v3] x86: Disable x2apic if nox2apic is specified

On 10/28/2010 10:53 PM, Suresh Siddha wrote:
> On Tue, 2010-10-26 at 23:27 -0700, Yinghai Lu wrote:
>> For
>> 1. x2apic preenabled system
>> 2. first kernel have x2apic enabled, and try to kexec second kernel with "nox2apic"
>>
>> Will put back cpu with apic id < 255 into xapic mode, instead of panic.
>>
>> -v2: use x2apic_disabled instead of nox2apic, Suggested by Thomas
>>      update x2apic_supported with x2apic_disabled, Suggested by Thomas
>>
>> -v3: add checking for boot cpu apic id > 255. in that case will just panic
>>      --- pointed out by Suresh.
>>
> 
> Can we please hold off in merging this patch for a bit? There are some
> subtleties in going back to xapic when the platform/cpu's are in x2apic
> mode. I will check and get back to you on this after KS.

sure. take you time.

	Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/