linux-kernel - Re: [PATCH] power: Fix typo in status comparison causing warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201010290949.11833.rjw@sisk.pl>
Date:	Fri, 29 Oct 2010 09:49:11 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Kevin Winchester <kjwinchester@...il.com>
Cc:	Pavel Machek <pavel@....cz>, linux-pm@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH] power: Fix typo in status comparison causing warning

On Friday, October 29, 2010, Kevin Winchester wrote:
> GCC version 4.5.1 gives the following warning:
> 
> 	drivers/base/power/runtime.c: In function ‘rpm_check_suspend_allowed’:
> 	drivers/base/power/runtime.c:146:25: warning: comparison between ‘enum dpm_state’ and ‘enum rpm_status’
> 
> which seems to be a typo in that dev->power.runtime_status
> should be compared instead of dev->power.status.
> 
> Signed-off-by: Kevin Winchester <kjwinchester@...il.com>
> ---
>  drivers/base/power/runtime.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> index 126ca49..02c652b 100644
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -143,7 +143,7 @@ static int rpm_check_suspend_allowed(struct device *dev)
>  
>  	/* Pending resume requests take precedence over suspends. */
>  	else if ((dev->power.deferred_resume
> -			&& dev->power.status == RPM_SUSPENDING)
> +			&& dev->power.runtime_status == RPM_SUSPENDING)
>  	    || (dev->power.request_pending
>  			&& dev->power.request == RPM_REQ_RESUME))
>  		retval = -EAGAIN;

Ouch, this actually is a serious bug.

Thanks a lot for the fix, will push to Linus shortly.

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/