linux-kernel - Re: Ensure FMODE_NONOTIFY is not set by userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Oct 2010 09:52:50 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Lino Sanfilippo <LinoSanfilippo@....de>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: Ensure FMODE_NONOTIFY is not set by userspace

On Fri, 2010-10-29 at 12:02 +0200, Lino Sanfilippo wrote:
> In fsnotify_open() ensure that FMODE_NONOTIFY is never set by userspace.
>     Also always call fsnotify_parent and fsnotify.

Did you find a place where the user was able to set FMODE_NONOTIFY?
That would be a problem.  But that's not what is happening here and
that's not what you are fixing.

This is a test if FMODE_NONOTIFY was already set then we do not send
notification about that file.  The current code is correct and your
patch breaks it....

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/