linux-kernel - Re: tproxy: added IPv6 support to the socket match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CCADAC7.5040309@trash.net>
Date:	Fri, 29 Oct 2010 16:31:35 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>
CC:	geert@...ux-m68k.org, bazsi@...abit.hu, hidden@...abit.hu,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: tproxy: added IPv6 support to the socket match

Am 28.10.2010 22:00, schrieb David Miller:
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Date: Thu, 28 Oct 2010 20:51:43 +0200
> 
>>> +       u8 tproto;
>>
>> tproto is unsigned...
>>
>>> +       const struct xt_socket_mtinfo1 *info = (struct xt_socket_mtinfo1 *) par->matchinfo;
>>> +
>>> +       tproto = ipv6_find_hdr(skb, &thoff, -1, NULL);
>>
>> but ipv6_find_hdr() returns int, and negative values for errors...
> 
> Thanks Geert, I'll fix it like so:
> 
> --------------------
> netfilter: xt_socket: Make tproto signed in socket_mt6_v1().
> 
> Otherwise error indications from ipv6_find_hdr() won't be noticed.
> 
> This required making the protocol argument to extract_icmp6_fields()
> signed too.
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: David S. Miller <davem@...emloft.net>

Thanks for taking care of this Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/