linux-kernel - Re: Ensure FMODE_NONOTIFY is not set by userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1288368607.3017.26.camel@localhost.localdomain>
Date:	Fri, 29 Oct 2010 12:10:07 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Lino Sanfilippo <LinoSanfilippo@....de>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: Ensure FMODE_NONOTIFY is not set by userspace

On Fri, 2010-10-29 at 16:27 +0200, Lino Sanfilippo wrote:
> On Fri, Oct 29, 2010 at 09:52:50AM -0400, Eric Paris wrote:
> > 
> > Did you find a place where the user was able to set FMODE_NONOTIFY?
> > That would be a problem.  But that's not what is happening here and
> > that's not what you are fixing.
> 
> I know its not happening here, but doing something like
> 
> #define MY_FLAG 0x1000000
> 
>  open("file/within/fanotify_protection", O_RDONLY | MY_FLAG);
> 
> from userspace is all that is needed to be ignored by fanotify :)
> There is nothing that checks if this flag has been set by userspace (or 
> did I miss something?)
> 
> Beside this since the flag should only be set within create_fd() or
> fanotify_init() there should never be a situation where 
> fsnotify_open() is called with a FMODE_NONOTIFY set (by the kernel).

You're right, I'm still not sure this is the best way to fix it, but
it's very broken.  I'll either commit your patch or post my own
today....

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/