linux-kernel - Re: [PATCH 2/2] jump label: disable due to compiler bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Oct 2010 12:18:28 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	Ingo Molnar <mingo@...e.hu>, Jason Baron <jbaron@...hat.com>,
	David Daney <ddaney@...iumnetworks.com>, rth@...hat.com,
	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	andi@...stfloor.org, roland@...hat.com,
	masami.hiramatsu.pt@...achi.com, fweisbec@...il.com,
	avi@...hat.com, davem@...emloft.net, vgoyal@...hat.com,
	sam@...nborg.org, tony@...eyournoodle.com, dsd@...top.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] jump label: disable due to compiler bug

On Fri, 2010-10-29 at 09:35 -0400, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@...dmis.org) wrote:
 
> > Then in the code have:
> > 
> > -#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL)
> > +#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL) \
> 
> Technically, you could remove the dependency on
> "defined(CONFIG_HAVE_ARCH_JUMP_LABEL)", because it is now dealt with at
> the Kconfig level (CONFIG_JUMP_LABEL depends on it).

Yeah, I noticed that just after hitting send.

> 
> > +	&& defined(JUMP_LABEL)
> 
> this would be defined(CONFIG_JUMP_LABEL)

Yep, this too, but thanks for pointing it out.


> 
> The rest looks fine,

Great, can I add your acked-by then?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/