linux-kernel - Re: [PATCH] xen: correct size of level2_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Oct 2010 18:37:35 +0100
From:	Ian Campbell <Ian.Campbell@...citrix.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen: correct size of level2_kernel_pgt

On Fri, 2010-10-29 at 18:22 +0100, Jeremy Fitzhardinge wrote:
> On 10/29/2010 08:56 AM, Ian Campbell wrote:
> > sizeof(pmd_t *) is 4 bytes on PAE leading to an allocation of only
> > 2048 bytes. The correct size is sizeof(pmd_t) giving us a full page
> > allocation.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> > Cc: Jeremy Fitzhardinge <jeremy@...p.org>
> > ---
> >
> > Applies to mainline since 2.6.36 and to xen.git 2.6.32 based trees
> 
> This is just for 2.6.37?

2.6.36.stable too, I think. I added stable@...nel.org to my patch header
but didn't "guilt refresh" so it didn't show up here.

Ian.

> 
>     J
> 
> >  arch/x86/xen/mmu.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> > index c237b81..21ed8d7 100644
> > --- a/arch/x86/xen/mmu.c
> > +++ b/arch/x86/xen/mmu.c
> > @@ -2126,7 +2126,7 @@ __init pgd_t *xen_setup_kernel_pagetable(pgd_t *pgd,
> >  {
> >  	pmd_t *kernel_pmd;
> >  
> > -	level2_kernel_pgt = extend_brk(sizeof(pmd_t *) * PTRS_PER_PMD, PAGE_SIZE);
> > +	level2_kernel_pgt = extend_brk(sizeof(pmd_t) * PTRS_PER_PMD, PAGE_SIZE);
> >  
> >  	max_pfn_mapped = PFN_DOWN(__pa(xen_start_info->pt_base) +
> >  				  xen_start_info->nr_pt_frames * PAGE_SIZE +
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/