linux-kernel - Re: [PATCH 2/2] jump label: disable due to compiler bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288376754.29632.19.camel@gandalf.stny.rr.com>
Date:	Fri, 29 Oct 2010 14:25:54 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Richard Henderson <rth@...hat.com>
Cc:	David Daney <ddaney@...iumnetworks.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Ingo Molnar <mingo@...e.hu>, Jason Baron <jbaron@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	andi@...stfloor.org, roland@...hat.com,
	masami.hiramatsu.pt@...achi.com, fweisbec@...il.com,
	avi@...hat.com, davem@...emloft.net, vgoyal@...hat.com,
	sam@...nborg.org, tony@...eyournoodle.com, dsd@...top.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] jump label: disable due to compiler bug

On Fri, 2010-10-29 at 11:13 -0700, Richard Henderson wrote:
> On 10/29/2010 10:48 AM, David Daney wrote:
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
> > 
> > Perhaps it could be integrated with the current checks for the presence of 'asm goto'
> 
> If you're looking for a cross-compile-able test, you can strip the
> testcase down to 
> 
> extern void abort(void);
> void g(int x, ...);
> void f(int x)
> {
>   if (x == 0)
>     g(0);
>   g(1, 2, 3, 4, 5, 6, 7);
>   asm goto ("XYZZY" : : : : label);
>   abort ();
>  label:
>   return;
> }
> 
> and use perl to notice the adjustment to esp before or after XYZZY.
> It should be fairly obvious looking at the assembly before and after
> the patch.
> 
> I don't know what sort of embedded processors supported by linux
> actually use ACCUMULATE_OUTGOING_ARGS.  Almost all ports don't, so
> I'd be pretty comfortable making this a 32-bit x86 only test, and
> let other targets just check that the test compiles.
> 

Thanks! I'll make a patch with this check (for x86_32) and queue it up
for 2.6.38. I think we are way past doing this for 2.6.37.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/