linux-kernel - Re: [PATCH 2/8] fs: factor inode disposal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101029044547.GN19804@ZenIV.linux.org.uk>
Date:	Fri, 29 Oct 2010 05:45:47 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Dave Chinner <david@...morbit.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] fs: factor inode disposal

On Fri, Oct 29, 2010 at 02:23:34PM +1100, Dave Chinner wrote:
>  		/*
> -		 * Move the inode off the IO lists and LRU once I_FREEING is
> -		 * set so that it won't get moved back on there if it is dirty.
> +		 * Move the inode off the LRU once I_FREEING is set so that it
> +		 * won't get moved back on.
>  		 */
>  		list_move(&inode->i_lru, &dispose);
> -		list_del_init(&inode->i_wb_list);

a) OK, so you've killed that list_del_init().  Good.
b) The comment is completely misleading.  We don't put I_FREEING inodes back on
LRU (or IO) lists, no matter where we find them.  What's happening here is
that we are collecting inodes to evict, period.

> -		 * Move the inode off the IO lists and LRU once I_FREEING is
> -		 * set so that it won't get moved back on there if it is dirty.
> +		 * Move the inode off the LRU once I_FREEING is
> +		 * set so that it won't get moved back on.

Ditto.

>  		/*
> -		 * Move the inode off the IO lists and LRU once I_FREEING is
> -		 * set so that it won't get moved back on there if it is dirty.
> +		 * Move the inode off the LRU once I_FREEING is
> +		 * set so that it won't get moved back on.
>  		 */
Ditto.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/