linux-kernel - Re: [PATCH] VIA Chrome integrated camera controller driver includes headers multiple times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101030084813.3581ea7e@bike.lwn.net>
Date:	Sat, 30 Oct 2010 08:48:13 -0600
From:	Jonathan Corbet <corbet@....net>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] VIA Chrome integrated camera controller driver includes
 headers multiple times

On Sat, 30 Oct 2010 15:32:32 +0200 (CEST)
Jesper Juhl <jj@...osbits.net> wrote:

> The VIA Chrome integrated camera controller driver includes both 
> 'linux/pci.h' and 'linux/device.h' twice. This gets rid of the duplicates.

Well, you see...I have teenage children.  So I've gotten very much used
to the idea that you have to ask for anything at *least* twice have any
chance of it actually happening.  Beyond that, the VIA controller has
certain adolescent behavior patterns of its own...watch out when it's
in a bad mood...so I just kind of fell into the habit of insisting.
Even then, I've been known to check with gcc -E to be *sure* it got
included.

Seriously, though, I'm not sure how that happened.   Obviously:

	Acked-by: Jonathan Corbet <corbet@....net>

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/