linux-kernel - Re: [PATCH] ipc: shm: fix information leak to userland

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Oct 2010 11:00:14 -0400
From:	Dan Rosenberg <drosenberg@...curity.com>
To:	segooon@...il.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipc: shm: fix information leak to userland

This one already got taken care of by Kees Cook:

http://lkml.org/lkml/2010/10/6/486

Thanks,
Dan

> Structure shmid_ds is copied to userland with shm_unused{,2,3}
> fields unitialized.  It leads to leaking of contents of kernel stack
> memory.
> Cc: stable@...nel.org
> Acked-by: Al Viro <viro@...IV.linux.org.uk>
> Signed-off-by: Vasiliy Kulikov <segooon@...il.com>
> ---
>  Compile tested.
>  ipc/shm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> diff --git a/ipc/shm.c b/ipc/shm.c
> index fd658a1..7d3bb22 100644
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_
>  	    {
>  		struct shmid_ds out;
>  
> +		memset(&out, 0, sizeof(out));
>  		ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm);
>  		out.shm_segsz	= in->shm_segsz;
>  		out.shm_atime	= in->shm_atime;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/