linux-kernel - [PATCH] IA64 perfmon: Change vmalloc to vzalloc and drop memset.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1010302131050.1572@swampdragon.chaosbits.net>
Date:	Sat, 30 Oct 2010 21:35:58 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	linux-kernel@...r.kernel.org
cc:	Stephane Eranian <eranian@....hp.com>,
	David Mosberger-Tang <davidm@....hp.com>,
	linux-ia64@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] IA64 perfmon: Change vmalloc to vzalloc and drop memset.

Hi,

vzalloc() nicely zeroes memory for us, so we don't have to do a vmalloc() 
and then manually memset() the returned memory when all we want is for it 
to be zero. Patch changes this for pfm_rvmalloc().


Signed-off-by: Jesper Juhl <jj@...osbits.net>
---
Untested patch since I have neither the hardware nor tools to even compile 
this.

 perfmon.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c
index 39e534f..3aee09d 100644
--- a/arch/ia64/kernel/perfmon.c
+++ b/arch/ia64/kernel/perfmon.c
@@ -829,10 +829,9 @@ pfm_rvmalloc(unsigned long size)
 	unsigned long addr;
 
 	size = PAGE_ALIGN(size);
-	mem  = vmalloc(size);
+	mem  = vzalloc(size);
 	if (mem) {
 		//printk("perfmon: CPU%d pfm_rvmalloc(%ld)=%p\n", smp_processor_id(), size, mem);
-		memset(mem, 0, size);
 		addr = (unsigned long)mem;
 		while (size > 0) {
 			pfm_reserve_page(addr);

-- 
Jesper Juhl <jj@...osbits.net>             http://www.chaosbits.net/
Plain text mails only, please      http://www.expita.com/nomime.html
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/