linux-kernel - Re: [PATCH 1/5] [PATCH 1/5] kconfig: Make localmodconfig handle environment variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=JXFppmiyyo=Hc614=FpDhOO4h8SLTs=CUOvQv@mail.gmail.com>
Date:	Sun, 31 Oct 2010 18:05:53 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>, Michal Marek <mmarek@...e.cz>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kbuild@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>,
	Roman Zippel <zippel@...ux-m68k.org>
Subject: Re: [PATCH 1/5] [PATCH 1/5] kconfig: Make localmodconfig handle
 environment variables

Hi,

On Fri, Oct 29, 2010 at 9:27 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Fri, 2010-10-29 at 20:26 -0400, Arnaud Lacombe wrote:
>> Hi,
>
>> Technically, it is _not_ an environment variable; it is a kconfig
>> symbol's name. In this particular case, both name collide and the
>> kconfig symbol happens to get its default value from the environment.
>> The real fixes, from my point of view, would be to have a perl binding
>> of the kconfig backend and get rid of read_kconfig(). That said, your
>> patch is broken if a symbol happen not to match an environment
>> variable (both in name and value).
>
> That sounds like a proper fix. Unfortunately, I don't have the time to
> work on this now, and although this fix works by coincidence, it
> never-the-less works, as suppose to just having localmodconfig crash.
>
yes, sure.

> But you are right. After KS and Plumbers, I'll work on doing something
> like that. That can probably solve some of the other issues I'm having
> (still keeping too many modules enabled).
>
I have some work in progress in this area: cleanup, better split
between the kconfig backend and frontend, and eventually a perl
binding. That would all be an interesting goal for .38 :-)

Currently I got the parser working within perl, but I'm not really
really sure of what I can currently do with it and how the whole thing
interface to one another :)

 - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/