linux-kernel - Re: [PATCH] SELinux: Do not assign the same value twice to the same variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288495964.3017.37.camel@localhost.localdomain>
Date:	Sat, 30 Oct 2010 23:32:44 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, Stephen Smalley <sds@...ho.nsa.gov>,
	James Morris <jmorris@...ei.org>,
	Eric Paris <eparis@...isplace.org>,
	Stephen Hemminger <shemminger@...tta.com>,
	ulia Lawall <julia@...u.dk>,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH] SELinux: Do not assign the same value twice to the
 same variable

On Sat, 2010-10-30 at 23:10 +0200, Jesper Juhl wrote:
> Hi,
> 
> It makes little sense to assign the same value to the same variable twice 
> when there is no code inbetween which could have changed the value of that 
> variable.

I don't like the patch.  The compiler will optimize it away (actually it
will optimize both of them away) and it make it clear that if a new
block is added in the middle that error codes can't be wrong....

It's just a personal preference I guess, but I like always setting the
error code before goto outs.  Is there a reason doing this is a problem?

-Eric
> 
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
> Untested patch below.
> 
>  policydb.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
> index 94f630d..e5a30ff 100644
> --- a/security/selinux/ss/policydb.c
> +++ b/security/selinux/ss/policydb.c
> @@ -1866,7 +1866,6 @@ static int genfs_read(struct policydb *p, void *fp)
>  			if (!newc)
>  				goto out;
>  
> -			rc = -ENOMEM;
>  			newc->u.name = kmalloc(len + 1, GFP_KERNEL);
>  			if (!newc->u.name)
>  				goto out;
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/