linux-kernel - Re: [PATCH] sched: Remove redundant #ifdef.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTim_Vc0c1WE8eiugqvYeJgDhODhKd4zDK12hA2Rt@mail.gmail.com>
Date:	Sun, 31 Oct 2010 15:01:43 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: Remove redundant #ifdef.

On Sun, Oct 31, 2010 at 2:44 PM, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Rakib Mullick <rakib.mullick@...il.com> wrote:
>
>>  Remove redundant #ifdef to wrap struct cpupri. root_domain structure
>> is declared under #ifdef CONFIG_SMP, no need to use #ifdef again
>> inside the structure.
>>
>>
>> Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
>> ---
>>
>> --- linus-36/kernel/sched.c   2010-10-21 02:30:22.000000000 +0600
>> +++ rakib-36/kernel/sched.c   2010-10-31 11:16:22.000000000 +0600
>> @@ -426,9 +426,7 @@ struct root_domain {
>>        */
>>       cpumask_var_t rto_mask;
>>       atomic_t rto_count;
>> -#ifdef CONFIG_SMP
>>       struct cpupri cpupri;
>> -#endif
>>  };
>
> The same patch was already sent by Christian Dietrich a few weeks ago, and it's
> upstream already:
>
>  ed2d372c0738: sched: Remove unnecessary #ifdef CONFIG_SMP
>

Ah... sorry for the noise :(. Should have checked it first. It seems
to me that I checked it..... but, certainly I missed it..


Thanks,

Rakib
> Thanks,
>
>        Ingo
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/