linux-kernel - Re: [PATCH v2 1/1] FS: cifs, remove unneeded NULL tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101101122315.5bcf6bac@tlielax.poochiereds.net>
Date:	Mon, 1 Nov 2010 12:23:15 -0400
From:	Jeff Layton <jlayton@...hat.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	sfrench@...ba.org, viro@...iv.linux.org.uk,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	jirislaby@...il.com, linux-cifs@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v2 1/1] FS: cifs, remove unneeded NULL tests

On Mon,  1 Nov 2010 16:08:55 +0100
Jiri Slaby <jslaby@...e.cz> wrote:

> Stanse found that pSMBFile in cifs_ioctl and file->f_path.dentry in
> cifs_user_write are dereferenced prior their test to NULL.
> 
> The alternative is not to dereference them before the tests. The patch is
> to point out the problem, you have to decide.
> 
> While at it we cache the inode in cifs_user_write to a local variable
> and use all over the function.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Steve French <sfrench@...ba.org>
> Cc: linux-cifs@...r.kernel.org
> Cc: Jeff Layton <jlayton@...hat.com>
> Cc: Christoph Hellwig <hch@...radead.org>
> ---
>  fs/cifs/file.c  |   25 +++++++++++--------------
>  fs/cifs/ioctl.c |    4 ----
>  2 files changed, 11 insertions(+), 18 deletions(-)
> 

Reviewed-by: Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/