linux-kernel - Re: [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h to lower cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101101174310.GA12632@suse.de>
Date:	Mon, 1 Nov 2010 10:43:10 -0700
From:	Greg KH <gregkh@...e.de>
To:	Haiyang Zhang <haiyangz@...uxonhyperv.com>
Cc:	haiyangz@...rosoft.com, hjanssen@...rosoft.com,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	virtualization@...ts.osdl.org
Subject: Re: [PATCH 03/10] staging: hv: Convert camel cased struct fields
	in hv.h to lower cases

On Mon, Nov 01, 2010 at 09:53:45AM -0700, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> Convert camel cased struct fields in hv.h to lower cases
> 
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Signed-off-by: Hank Janssen <hjanssen@...rosoft.com>

Why did I get two different copies of some of these patches?  Are they
different?

>  /* The one and only */
> -struct hv_context gHvContext = {
> -	.SynICInitialized	= false,
> -	.HypercallPage		= NULL,
> -	.SignalEventParam	= NULL,
> -	.SignalEventBuffer	= NULL,
> +struct hv_context g_hv_context = {

What is the "g_" for?  Why are you keeping the unneeded, and unwanted
hungarian notation around?  Please don't do that.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/