linux-kernel - Re: [PATCH] Perf, AMD: Prefer kzalloc() over kmalloc()+memset() in amd_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1011011857220.9616@swampdragon.chaosbits.net>
Date:	Mon, 1 Nov 2010 18:57:39 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
cc:	linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Stephane Eranian <eranian@...gle.com>,
	"robert.richter" <robert.richter@....com>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Borislav Petkov <bp@...64.org>
Subject: Re: [PATCH] Perf, AMD: Prefer kzalloc() over kmalloc()+memset() in
 amd_alloc_nb()

On Mon, 1 Nov 2010, Peter Zijlstra wrote:

> On Sat, 2010-10-30 at 21:06 +0200, Jesper Juhl wrote:
> > Hi,
> > 
> > I believe this would be an improvement?
> > 
> > Prefer kzalloc() over kmalloc()+memset() in amd_alloc_nb().
> > 
> > 
> > Signed-off-by: Jesper Juhl <jj@...osbits.net>
> > ---
> 
> 
> I've changed it to..
> 
> ---
> Subject: perf, amd: Use kmalloc_node(,__GFP_ZERO) for northbridge structure allocation
> From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Date: Mon Nov 01 18:52:05 CET 2010
> 
> Jasper suggested we use the zeroing capability of the allocators
> instead of calling memset ourselves. Add node affinity while we're at
> it.
> 
> Reported-by: Jesper Juhl <jj@...osbits.net>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

Fine by me.

-- 
Jesper Juhl <jj@...osbits.net>             http://www.chaosbits.net/
Plain text mails only, please      http://www.expita.com/nomime.html
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/