lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Nov 2010 16:15:01 +0900 From: "Tomoya MORINAGA" <tomoya-linux@....okisemi.com> To: "Marc Kleine-Budde" <mkl@...gutronix.de> Cc: "Wolfgang Grandegger" <wg@...ndegger.com>, "David S. Miller" <davem@...emloft.net>, "Wolfram Sang" <w.sang@...gutronix.de>, "Christian Pellegrin" <chripell@...e.org>, "Barry Song" <21cnbao@...il.com>, "Samuel Ortiz" <sameo@...ux.intel.com>, <socketcan-core@...ts.berlios.de>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <andrew.chih.howe.khor@...el.com>, <qi.wang@...el.com>, <margie.foster@...el.com>, <yong.y.wang@...el.com>, "Masayuki Ohtake" <masa-korg@....okisemi.com>, <kok.howg.ewe@...el.com>, <joel.clark@...el.com> Subject: Re: [PATCH net-next-2.6 v2] can: Topcliff: PCH_CAN driver: Fix build warnings On Friday, October 29, 2010 9:57 PM : Marc Kleine-Budde wrote: >>>> SW must check busy flag of CAN register. >>>> This is a Topcliff HW specification. >>> Maybe the busy check could also be done *before* the Message RAM is >>> accessed to avoid (or minimize) waiting. >> Yes, *before* is right. >> If there is *after* processing, this is a bug. >> Can you see anyway ? >Sorry I don't understand what you mean. Sorry, my English had mistake. I show my comment below again. - If there is *after* processing, this is a bug. - Can you see the point anywhere ? > You probably know the datasheet, but I don't, although I've printed > chapter 13 from the Intel Controller Hub EG20T datasheet, but it's 50+ > pages. If the hardware needs the busy waiting in the hot tx path a > pointer to the respective section in the manual is a good idea. Just > something like: Though "Oliver Hartkopp" found the place of Datasheet EG20T and notified with the mailing-list, Have you read the following ? http://edc.intel.com/Platforms/Atom-E6xx/#hardware >>> You have to change the definition of the regs struct a bit: >>>> u32 if1_mcont; >>>> u32 if1_data[4]; >>>> u32 reserve2; >> Uh, I can't find this. Where is this ? >Here's a patch to illustrate what I meant: I understand. Thanks, Tomoya(OKI SEMICONDUCTOR CO., LTD.) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists