linux-kernel - Re: New 2.6.36 checkpatch complaints about leading whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTiknBbdUji2mATH159US1J_yJE5egOFkU4TH5jdb@mail.gmail.com>
Date:	Mon, 1 Nov 2010 08:29:40 +0100
From:	Bart Van Assche <bvanassche@....org>
To:	Andy Whitcroft <apw@...onical.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Vladislav Bolkhovitin <vst@...b.net>
Subject: Re: New 2.6.36 checkpatch complaints about leading whitespace

On Mon, Nov 1, 2010 at 5:10 AM, Andy Whitcroft <apw@...onical.com> wrote:
>
> On Sat, Oct 30, 2010 at 11:35:22AM +0200, Bart Van Assche wrote:
> > Hello Andy,
> >
> > Apparently the checkpatch.pl script as included in 2.6.36 complains if
> > continued lines start with whitespace. An example:
> >
> > [ ... ]
> > +#if defined(MACRO_NAME_1) || defined(MACRO_NAME_2) \
> > +  || defined(MACRO_NAME_3)
> > [ ... ]
> >
> > checkpatch.pl reports the following warning for the above patch excerpt:
> >
> > WARNING: please, no space for starting a line,
> >                                 excluding comments
> >
> > Is that a feature or an unintended side effect of recent checkpatch changes ?
>
> My personal expectation would be for that second line to be indented
> with a tab.  But I might be convinced otherwise?

There are also other preprocessor directives on which the 2.6.36
checkpatch complains, e.g.:

#warning A very long warning message that takes multiple lines and of which\
 the second line starts with a space.

Why does the 2.6.36 checkpatch complain that the second line should
start with a tab instead of a space (which would make the message
really ugly) ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/