linux-kernel - Re: [PATCH] iSeries: Don't leak if allocations fail in mf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101102071025.2fe5e6ca.sfr@canb.auug.org.au>
Date:	Tue, 2 Nov 2010 07:10:25 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	michael@...erman.id.au
Cc:	Jesper Juhl <jj@...osbits.net>, Paul Mackerras <paulus@...ba.org>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...g.org.au>
Subject: Re: [PATCH] iSeries: Don't leak if allocations fail in
 mf_getSrcHistory

Hi Jesper,

On Mon, 01 Nov 2010 22:10:42 +1100 Michael Ellerman <michael@...erman.id.au> wrote:
>
> On Sat, 2010-10-30 at 19:20 +0200, Jesper Juhl wrote:
> > 
> > If memory is tight and a dynamic allocation fails there's no reason to 
> > make a bad situation worse by leaking memory.
> > 
> > mf_getSrcHistory potentially leaks pages[0-3]. I believe the right thing 
> > to do is to free that memory again before returning -ENOMEM - which is 
> > what this patch does.
> > 
> > I realize that the function is under '#if 0' so this probably doesn't 
> > matter much, but I assume that the function is still there for a reason 
> > (but I could be wrong, I don't know the powerpc code).
> > Anyway, I suggest we remove the leak.
> 
> Stephen is the iSeries maintainer, and I think he #if 0'ed the code. But
> I don't think it will ever be un-ifdef'ed, so should probably just be
> removed.

Well, only unofficially iseries maintainer :-)

Yes, just remove the whole function ... it was never used and never will
be.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped