linux-kernel - Re: [PATCH 2/6] avr32: get rid of useless args in signal.c before other work there

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1288598919.2843.22.camel@hcegtvedt>
Date:	Mon, 01 Nov 2010 09:08:39 +0100
From:	Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Al Viro <viro@....linux.org.uk>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 2/6] avr32: get rid of useless args in signal.c before
 other work there

On Mon, 2010-11-01 at 08:02 +0000, Al Viro wrote: 
> On Mon, Nov 01, 2010 at 08:58:29AM +0100, Hans-Christian Egtvedt wrote:
> > On Tue, 2010-09-28 at 03:57 +0100, Al Viro wrote: 
> > > Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> > > @@ -261,11 +261,12 @@ handle_signal(unsigned long sig, struct k_sigaction *ka, siginfo_t *info,
> > >   * doesn't want to handle. Thus you cannot kill init even with a
> > >   * SIGKILL even by mistake.
> > >   */
> > > -int do_signal(struct pt_regs *regs, sigset_t *oldset, int syscall)
> > > +static void do_signal(struct pt_regs *regs, int syscall)
> > >  {
> > >  	siginfo_t info;
> > >  	int signr;
> > >  	struct k_sigaction ka;
> > > +	sigset_t *oldset;
> > 
> > Should be initialized as it is checked in the else if block further
> > below.
> 
> That else if should be simply else...

Ah, that made a lot more sense. I'm still on my first cup of coffee
brushing dust of your series.

-- 
Hans-Christian Egtvedt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/