linux-kernel - Re: [PATCH 2/4] w35und: Kill struct hwdata ->NullPacketCount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101101211653.GF22934@elf.ucw.cz>
Date:	Mon, 1 Nov 2010 22:16:53 +0100
From:	Pavel Machek <pavel@....cz>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] w35und: Kill struct hwdata ->NullPacketCount

On Mon 2010-11-01 22:29:29, Pekka Enberg wrote:
> This patch kills the NullPacketCount member of struct hwdata. It's not used for
> anything so it's safe to remove it.
> 
> Cc: Pavel Machek <pavel@....cz>
> Signed-off-by: Pekka Enberg <penberg@...nel.org>

ACK.

> ---
>  drivers/staging/winbond/wbhal.h |    6 ------
>  drivers/staging/winbond/wbusb.c |    9 ---------
>  2 files changed, 0 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/winbond/wbhal.h b/drivers/staging/winbond/wbhal.h
> index 821a1b3..6f4cd76 100644
> --- a/drivers/staging/winbond/wbhal.h
> +++ b/drivers/staging/winbond/wbhal.h
> @@ -342,9 +342,6 @@ struct wb35_descriptor { /* Skip length = 8 DWORD */
>  	void	*buffer_address[MAX_DESCRIPTOR_BUFFER_INDEX];
>  };
>  
> -
> -#define DEFAULT_NULL_PACKET_COUNT	180000	/* 180 seconds */
> -
>  #define MAX_TXVGA_EEPROM		9	/* How many word(u16) of EEPROM will be used for TxVGA */
>  #define MAX_RF_PARAMETER		32
>  
> @@ -517,9 +514,6 @@ struct hw_data {
>  
>  	/* For error recover */
>  	u32		HwStop;
> -
> -	/* For avoid AP disconnect */
> -	u32		NullPacketCount;
>  };
>  
>  #endif
> diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
> index 82040f4..dcb6d5b 100644
> --- a/drivers/staging/winbond/wbusb.c
> +++ b/drivers/staging/winbond/wbusb.c
> @@ -611,15 +611,6 @@ static void hal_led_control(unsigned long data)
>  			}
>  			break;
>  		}
> -
> -		/* Active send null packet to avoid AP disconnect */
> -		if (pHwData->LED_LinkOn) {
> -			pHwData->NullPacketCount += TimeInterval;
> -			if (pHwData->NullPacketCount >=
> -			    DEFAULT_NULL_PACKET_COUNT) {
> -				pHwData->NullPacketCount = 0;
> -			}
> -		}
>  	}
>  
>  	pHwData->time_count += TimeInterval;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/