linux-kernel - [tip:x86/urgent] x86, mm: Fix section mismatch in tlb.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-cf38d0ba7efdc476815768b2b999b27cfae69747@git.kernel.org>
Date:	Mon, 1 Nov 2010 09:13:06 GMT
From:	tip-bot for Rakib Mullick <rakib.mullick@...il.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	rakib.mullick@...il.com, shaohua.li@...el.com, tglx@...utronix.de,
	borislav.petkov@....com, mingo@...e.hu
Subject: [tip:x86/urgent] x86, mm: Fix section mismatch in tlb.c

Commit-ID:  cf38d0ba7efdc476815768b2b999b27cfae69747
Gitweb:     http://git.kernel.org/tip/cf38d0ba7efdc476815768b2b999b27cfae69747
Author:     Rakib Mullick <rakib.mullick@...il.com>
AuthorDate: Mon, 1 Nov 2010 12:53:50 +0600
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Mon, 1 Nov 2010 10:09:07 +0100

x86, mm: Fix section mismatch in tlb.c

Mark tlb_cpuhp_notify as __cpuinit. It's basically a callback
function, which is called from __cpuinit init_smp_flash(). So -
it's safe.

We were warned by the following warning:

 WARNING: arch/x86/mm/built-in.o(.text+0x356d): Section mismatch
 in reference from the function tlb_cpuhp_notify() to the
 function .cpuinit.text:calculate_tlb_offset()
 The function tlb_cpuhp_notify() references
 the function __cpuinit calculate_tlb_offset().
 This is often because tlb_cpuhp_notify lacks a __cpuinit
 annotation or the annotation of calculate_tlb_offset is wrong.

Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
Cc: Borislav Petkov <borislav.petkov@....com>
Cc: Shaohua Li <shaohua.li@...el.com>
LKML-Reference: <AANLkTinWQRG=HA9uB3ad0KAqRRTinL6L_4iKgF84coph@...l.gmail.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/mm/tlb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 4935848..12cdbb1 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -251,7 +251,7 @@ static void __cpuinit calculate_tlb_offset(void)
 	}
 }
 
-static int tlb_cpuhp_notify(struct notifier_block *n,
+static int __cpuinit tlb_cpuhp_notify(struct notifier_block *n,
 		unsigned long action, void *hcpu)
 {
 	switch (action & 0xf) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/