linux-kernel - Re: [PATCH 1/7] [AVR32] don't check platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288605483.2843.71.camel@hcegtvedt>
Date:	Mon, 01 Nov 2010 10:58:03 +0100
From:	Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, David Vrabel <dvrabel@...om.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Haavard Skinnemoen <hskinnemoen@...el.com>
Subject: Re: [PATCH 1/7] [AVR32] don't check platform_get_irq's return
 value against zero

On Tue, 2010-10-19 at 08:45 +0200, Uwe Kleine-König wrote: 
> On Wed, Dec 16, 2009 at 05:10:03PM +0100, Uwe Kleine-König wrote:
> > platform_get_irq returns -ENXIO on failure, so !int_irq was probably
> > always true.  Better use (int)int_irq <= 0.  Note that a return value of
> > zero is still handled as error even though this could mean irq0.

Indeed, but external interrupts are numbered after the internal
interrupt lines, so in practice this does not happen. At least for now
with the AP700X series.

> > This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
> > changed the return value of platform_get_irq from 0 to -ENXIO on error.

Thanks for this fix.

> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > Cc: David Vrabel <dvrabel@...om.com>
> > Cc: Greg Kroah-Hartman <gregkh@...e.de>
> > Cc: Haavard Skinnemoen <hskinnemoen@...el.com>

Acked-by: Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>

<snipp>

-- 
Hans-Christian Egtvedt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/