linux-kernel - Re: [PATCH] mfd: Add initial WM8958 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101102131348.GB21476@opensource.wolfsonmicro.com>
Date:	Tue, 2 Nov 2010 09:13:49 -0400
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	alsa-devel@...a-project.org, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: Add initial WM8958 support

On Mon, Nov 01, 2010 at 11:52:04PM -0200, Thiago Farina wrote:
> On Mon, Nov 1, 2010 at 4:20 PM, Mark Brown

> > +enum wm8994_type {
> > +       WM8994 = 0,
> > +       WM8958 = 1,
> > +};

> Don't need to initialize with = 0 and with = 1. This is done by default.

There is no runtime cost to doing this and so where the values are
important I feel the clarity from documenting the actual values is
useful, it saves anyone having to figure out if they are what is
expected.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/