linux-kernel - Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=4hi-zNSFPvHnTEPeweTuqUwni+Aij_E6Zj8i5@mail.gmail.com>
Date:	Tue, 2 Nov 2010 16:23:22 +0200
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-usb <linux-usb@...r.kernel.org>,
	linux-main <linux-kernel@...r.kernel.org>,
	linux-omap <linux-omap@...r.kernel.org>,
	Felipe Balbi <balbi@...com>, Greg KH <greg@...ah.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>, Hao Wu <hao.wu@...el.com>,
	Alan Cox <alan@...ux.intel.com>,
	Mike Rapoport <mike@...pulab.co.il>
Subject: Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff

2010/11/2 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
> On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote:
>> Add missing dependencies, and remove redundant ones, and select sensible
>> defaults.
>>
>> This is more user-friendly, and logical.
>>
>>  - TWL4030_CORE people should be able to compile without ARM
>>  - REGULATOR_TWL4030 if TWL4030_CORE and REGULATOR, it's pretty clear we
>>    want this
>>  - USB_GADGET_SELECTED is already inside USB_GADGET
>>  - USB_GADGET_OMAP only works on ARCH_OMAP1, and USB_OTG_UTILS is
>>    already selected by NOP_USB_XCEIV
>>  - USB_GADGET_R8A66597 is meant for ARCH_SHMOBILE
>>  - USB_MUSB_HDRC needs either NOP_USB_XCEIV, or TWL4030_USB
>>  - USB_MUSB_AM35X, NOP_USB_XCEIV is already selected because MACH_OMAP3EVM
>>
>> Finally, move:
>> config USB_MUSB_HDRC
>>       select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN)
>>       select TWL4030_USB if MACH_OMAP_3430SDP
>>
>> To:
>> config TWL4030_USB
>>       default y if ARCH_OMAP3
>>
>> config NOP_USB_XCEIV
>>       default y if ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>
> All changes look fine to me, but I think you will need to split up this
> patch for the different subsystem maintainers.

Ok, will do.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/