| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Nov 2010 08:27:38 -0700 From: Greg KH <gregkh@...e.de> To: Arnaud Patard <arnaud.patard@...-net.org> Cc: sowani@...il.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2.6.36 1/1] xgifb: change obsolete pci_find_device() with pci_get_device(). On Tue, Nov 02, 2010 at 04:21:36PM +0100, Arnaud Patard wrote: > Atul Sowani <sowani@...il.com> writes: > Hi, > > > Replaced obsolete pci_find_device() calls with pci_get_device() calls. This is > > recommended in pci.txt filei in PCI Documentation. > > > > Signed-off-by: Atul Sowani <sowani@...il.com> > > --- > > diff -uprN a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c > > --- a/drivers/staging/xgifb/XGI_main_26.c 2010-10-21 02:00:22.000000000 +0530 > > +++ b/drivers/staging/xgifb/XGI_main_26.c 2010-11-01 14:25:21.032436943 +0530 > > @@ -483,7 +483,7 @@ XGIfb_query_VGA_config_space(struct xgi_ > > break; > > } > > > > - pdev = pci_find_device(PCI_VENDOR_ID_SI, nbridge_id, pdev); > > + pdev = pci_get_device(PCI_VENDOR_ID_SI, nbridge_id, pdev); > > if (pdev) > > valid_pdev = 1; > > hmm... I guess that a pci_dev_put() call is lacking if it has been found. Exactly, that is what is needed here. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists