linux-kernel - Re: drivers/media/IR/ir-keytable.c::ir_getkeycode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=AGWGv2WPuGQ4bF7N4TSAbU5YMjry9beXyvspk@mail.gmail.com>
Date:	Tue, 2 Nov 2010 12:04:56 -0400
From:	Jarod Wilson <jarod@...sonet.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	mchehab@...hat.com
Subject: Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be
 used uninitialized

On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote:
>> Commit 9f470095068e "Input: media/IR - switch to using new keycode
>> interface" added the following build warning:
>>
>> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
>> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function
>>
>> It is due to an actual bug but I don't know the fix.
>>
>
> The patch below should fix it. I wonder if Linus released -rc1 yet...

Looks like it missed rc1.

> Input: ir-keytable - fix uninitialized variable warning
>
> From: Dmitry Torokhov <dmitry.torokhov@...il.com>
>
> We were forgetting to set up proper return value in success path causing
> ir_getkeycode() to fail intermittently:
>
> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used
> uninitialized in this function
>
> Reported-by: Stefan Richter <stefanr@...6.in-berlin.de>
> Signed-off-by: Dmitry Torokhov <dtor@...l.ru>

Acked-by: Jarod Wilson <jarod@...hat.com>


-- 
Jarod Wilson
jarod@...sonet.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/