linux-kernel - Re: [RFC][PATCH] direct-io: btrfs: avoid splitting dio requests for non-btrfs filesystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101102185833.GA7404@infradead.org>
Date:	Tue, 2 Nov 2010 14:58:33 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Josef Bacik <josef@...hat.com>
Cc:	Christian Ehrhardt <ehrhardt@...ux.vnet.ibm.com>,
	Jeff Moyer <jmoyer@...hat.com>,
	Josef Bacik <jbacik@...hat.com>,
	Chris Mason <chris.mason@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-btrfs@...r.kernel.org,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: Re: [RFC][PATCH] direct-io: btrfs: avoid splitting dio requests for
 non-btrfs filesystems

On Tue, Nov 02, 2010 at 10:57:18AM -0400, Josef Bacik wrote:
> (which I did anyway because of my bug).  So maybe the right idea is to rip out
> my logical offset tests altogether and fix dio so we treat buffer_boundary()
> like gospel.  That way Btrfs can get what it needs without having this weird
> special code, and then we can look at how other fs's set buffer_boundary (I'm
> pretty sure ext2/3 are the only ones) and make sure they are setting it when
> they really mean to.

That sounds pretty reasonable to me.  I really don't like the flag in
the kiocb in this patch, and handling it as part of the get_blocks
callback sounds much better to me.  I don't know enough about the
bounary blocks to know if we can reuse them - if we can it's perfect,
if not another buffer flag seems like the way to go.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/