linux-kernel - Re: [PATCH 05/10] staging: hv: Convert camel cased functions in hv.c to lower cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101102170406.GA4557@jenkins.home.ifup.org>
Date:	Tue, 2 Nov 2010 10:04:08 -0700
From:	Brandon Philips <brandon@...p.org>
To:	Haiyang Zhang <haiyangz@...uxonhyperv.com>
Cc:	haiyangz@...rosoft.com, hjanssen@...rosoft.com, gregkh@...e.de,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	virtualization@...ts.osdl.org
Subject: Re: [PATCH 05/10] staging: hv: Convert camel cased functions in
 hv.c to lower cases

On 13:46 Mon 01 Nov 2010, Haiyang Zhang wrote:
> -static int HvQueryHypervisorInfo(void)
> +static int hvquery_hypervisor_info(void)
> -static u64 HvDoHypercall(u64 control, void *input, void *output)
> +static u64 hvdo_hypercall(u64 control, void *input, void *output)

Should these be hv_do_hypercall and hv_query_hypervisor? That seems to
be the style in the rest of the patch:

> -int HvInit(void)
> +int hv_init(void)

> -void HvCleanup(void)
> +void hv_cleanup(void)

> -u16 HvPostMessage(union hv_connection_id connection_id,
> +u16 hv_post_message(union hv_connection_id connection_id,

> -u16 HvSignalEvent(void)
> +u16 hv_signal_event(void)

Cheers,

	Brandon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/